Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdlib_variants: Avoid types being implicitly duplicated by signature builder #23

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Stdlib_variants: Avoid types being implicitly duplicated by signature builder #23

merged 3 commits into from
Sep 29, 2024

Conversation

just-max
Copy link
Owner

@just-max just-max commented Aug 3, 2024 •
edited
Loading

Otherwise, things like this are broken:

let _ = Result.get_ok (Ok 1 : _ result)

since result is defined as a new type in the Stdlib_alerting interface.

@just-max
Copy link
Owner Author

Manually writing out referenced types is annoying, but there are few enough types in standard library signatures that it's acceptable. It's also not clear what the best way to automatically choose a type to reference would be (what if something shadows the standard library?), so it's fine as-is.

@just-max just-max merged commit 17b3ba4 into main Sep 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@just-max